Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): update the type definition of $el property #8809

Merged
merged 1 commit into from
Dec 1, 2018
Merged

fix(types): update the type definition of $el property #8809

merged 1 commit into from
Dec 1, 2018

Conversation

kaorun343
Copy link
Contributor

to be able to define $el as SVGElement

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:

@ktsn
Copy link
Member

ktsn commented Oct 13, 2018

Just a note: this would breaks existing apps which is using $el. The users need to annotate the type to HTMLElement or so by their hand.

@yyx990803 yyx990803 merged commit 3cd4af4 into vuejs:dev Dec 1, 2018
@RnbWd
Copy link

RnbWd commented Dec 17, 2018 •
edited
Loading

@ktsn how do you reassign Element to HTMLElement?

edit: this seems to work const element = this.$el as HTMLElement

@kaorun343 kaorun343 deleted the update_types branch December 18, 2018 05:37
@slangeder
Copy link

I am not a fan of this change.
Now I have to cast every $el to HTMLElement when I want to use it.
I worked around by writing a plugin that provides $el casted to HTMLElement as a new property $html.

Does Vue really need to support components / apps on SVG elements?

@LinusBorg
Copy link
Member

Does Vue really need to support components / apps on SVG elements?

This is a 100% yes.

f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
fix(types): support typing $el as SVGElement (vuejs#8809)
d101f6c
@kjleitz kjleitz mentioned this pull request Jan 25, 2019
Open
@kjleitz
Copy link

kjleitz commented Jan 29, 2019

This was a breaking change for our build—shouldn't it have been in at least a minor version update, as opposed to a patch update?

@yyx990803
Copy link
Member

@kjleitz yes we should have. It was a mistake to release this in a patch. Apologies if this caused inconvenience on your side.

robinchow added a commit to robinchow/vuejs.org that referenced this pull request Feb 13, 2019
@robinchow
Updated el and $el from HTMLElement to Element
56dfb5e 
As per this merged PR: vuejs/vue#8809
robinchow added a commit to robinchow/vuejs.org that referenced this pull request Feb 13, 2019
@robinchow
Updated el and $el from HTMLElement to Element
8cb56cc 
As per the original Typescript definitions plus this merged PR: vuejs/vue#8809
@robinchow robinchow mentioned this pull request Feb 13, 2019
Merged
sdras pushed a commit to vuejs/v2.vuejs.org that referenced this pull request Feb 18, 2019
@robinchow @sdras
Updated el and $el from HTMLElement to Element (#1996)
bfe2649 
As per this merged PR: vuejs/vue#8809
Jinjiang pushed a commit to vuejs/v2.cn.vuejs.org that referenced this pull request Feb 18, 2019
@robinchow @Jinjiang
Updated el and $el from HTMLElement to Element (#1996)
fa3ca76 
As per this merged PR: vuejs/vue#8809
Justineo pushed a commit to vuejs/v2.cn.vuejs.org that referenced this pull request Feb 18, 2019
@robinchow @Justineo
Updated el and $el from HTMLElement to Element (#1996)
f2e727e 
As per this merged PR: vuejs/vue#8809
@kjleitz
Copy link

kjleitz commented Mar 19, 2019

@yyx990803 no worries, man! Thank you guys for all your hard work. Vue is amazing.

phanan pushed a commit to phanan-forks/vuejs.org that referenced this pull request Mar 20, 2019
@robinchow @phanan
Updated el and $el from HTMLElement to Element (vuejs#1996)
6721136 
As per this merged PR: vuejs/vue#8809
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
@aJean
fix(types): support typing $el as SVGElement (vuejs#8809)
c246cc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

Assignees
No one assigned
Labels
ready to merge typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kaorun343 @ktsn @RnbWd @slangeder @LinusBorg @kjleitz @yyx990803